Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick-and-dirty patch for KSP 1.5.1 #227

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

asdfCYBER
Copy link

Yes, I reuploaded things multiple times and there are too many commits. Please don't blame me, I never use GitHub.

@blowfishpro
Copy link
Contributor

How come it's showing so many changes in the .csproj files even though nothing changed. Did the line endings change or something like that?

It's also probably not a good idea to change the hint paths for the DLLs, since these are going to be specific to your system. In general I actually would recommend not using hint paths at all and setting reference paths in visual studio (which are stored in your local .csproj.user and not under version control), but it's up to the project owner to decide how they want to organize things.

@asdfCYBER
Copy link
Author

asdfCYBER commented Jun 15, 2018

@blowfishpro I recompiled the entire project against the newer dlls, and VS automatically changed the hintpaths, which were already in the original file. I will revert the .csproj files (they aren't packed in the dlls, are they?).

@asdfCYBER asdfCYBER changed the title Quick-and-dirty patch for KSP 1.4.3 Quick-and-dirty patch for KSP 1.4.5 Aug 5, 2018
@BlueNexus
Copy link

Any idea when this is getting merged?

@asdfCYBER asdfCYBER changed the title Quick-and-dirty patch for KSP 1.4.5 Quick-and-dirty patch for KSP 1.5.1 Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants